From 50a9286895ed90c5b3044844c5f5a69859f85371 Mon Sep 17 00:00:00 2001
From: Chi Cong Tran <chi-cong.tran@polizei.niedersachsen.de>
Date: Tue, 30 Sep 2025 08:16:28 +0200
Subject: [PATCH] refactoring magic strings API URLs in upload view

---
 src/routes/(angemeldet)/upload/+page.svelte | 8 ++++----
 src/routes/index.ts                         | 7 +++++--
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/routes/(angemeldet)/upload/+page.svelte b/src/routes/(angemeldet)/upload/+page.svelte
index 80de66c..1abf7a1 100644
--- a/src/routes/(angemeldet)/upload/+page.svelte
+++ b/src/routes/(angemeldet)/upload/+page.svelte
@@ -9,7 +9,7 @@
 	import shortenFileSize from '$lib/helper/shortenFileSize.js';
 	import Exclamation from '$lib/icons/Exclamation.svelte';
 	import FileRect from '$lib/icons/File-rect.svelte';
-	import { ROUTE_NAMES } from '../../index.js';
+	import { API_ROUTES, ROUTE_NAMES } from '../../index.js';
 
 	export let form;
 
@@ -152,7 +152,6 @@
 		return true;
 	}
 
-	// `/(angemeldet)/view` return true or false
 	async function checkVorgangExists(vorgangName: string) {
 		if (vorgangName == '') {
 			vorgangPIN = vorgangPINOld;
@@ -160,7 +159,8 @@
 		}
 
 		try {
-			const url = `/api/list/${vorgangName}`;
+			// `HEAD` method
+			const url = API_ROUTES.VORGANG_NAME_EXIST(vorgangName);
 			const response = await fetch(url, { method: 'HEAD' });
 
 			if (response.status === 200) {
@@ -186,7 +186,7 @@
 	async function getVorgangPIN(vorgangName: string) {
 		if (vorgangName == '') return;
 
-		let url = `/api/vorgang/${vorgangName}/vorgangPIN`;
+		let url = API_ROUTES.VORGANG_PIN(vorgangName);
 		const response = await fetch(url);
 
 		if (response.status == 200) {
diff --git a/src/routes/index.ts b/src/routes/index.ts
index b7403f7..0c2fa5f 100644
--- a/src/routes/index.ts
+++ b/src/routes/index.ts
@@ -24,10 +24,13 @@ export const ROUTE_NAMES = {
 	ANMELDUNG: '/anmeldung',
 	ANMELDUNG_LOGIN: '/anmeldung?/login',
 	ANMELDUNG_LOGOUT: '/anmeldung?/logout',
-	ANMELDUNG_GET_VORGANG_BY_TOKEN: '/anmeldung?/getVorgangByToken',
+	ANMELDUNG_GET_VORGANG_BY_TOKEN: '/anmeldung?/getVorgangByToken'
 };
 
 export const API_ROUTES = {
 	LIST: '/api/list',
-	VORGANG: (vorgangToken: string) => `/api/list/${vorgangToken}`
+	VORGANG: (vorgangToken: string) => `/api/list/${vorgangToken}`,
+	// via `HEAD` method
+	VORGANG_NAME_EXIST: (vorgangName: string) => `/api/list/${vorgangName}`,
+	VORGANG_PIN: (vorgangName: string) =>`/api/vorgang/${vorgangName}/vorgangPIN`
 };