innohub/tatort
7
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

f034_sqlite_database #19

Merged
jared merged 34 commits from f034_sqlite_database into development 2025-07-24 14:34:39 +02:00
Conversation 8 Commits 34 Files Changed 21 +2382 -866
trachi93 commented 2025-07-22 11:24:31 +02:00
Owner
Copy Link
No description provided.
trachi93 added 29 commits 2025-07-22 11:24:31 +02:00
populate db with default user 8d92e94bd6
include packages fa69fa9dcd
Merge branch 'development' into f034_merge_dev 64aa1d404e
replace with 0c6dbe30ab
remove old, commented implementation of authenticate dc2d038b1b
refactor db design c034064d41
add uuid-package for token generation f6513c9ed8
refactor init-script and display tables with data 8b1b3532fc
adding new vorgang in database 40599f4ffa
listing of cases based on db 307894c980
refactor getVorgaenge to return vorgaenge as objects ffa34b3b61
store tatort under case token name 564716e853
correctly display Vorgangsname in Vorgang page f7245fac90
rewrite vorgang exist and token validation check to use DB 9ddec90214
remove console.log 83bcaca918
prefill homepage with token f2bde76969
add copy button for sharing vorgang 8408d63f40
refactor DB access a7eb81151f
fix import error from default to explicit import cd5389666e
refactoring: 'Datei zu Vorgang hinzufügen' an DB angepasst 484acd3bcf
make 'Vorgangsname' column unique fa59db7a88
refactor 'Datei zu Vorgang hinzufügen': Add model files to existing cases 873a382f69
remove console.logs 5070ac9f7a
delete functionality for Vorgang in DB 51d3f19f3e
document DB initialization script b8e5031669
refactoring part 1: camelcase naming, token vs pw naming 34d5034a71
refactoring part 2: mainly consolidation of token, ids and passwort 143bb128a5
refactoring part 3: delete function of vorgang uses caseToken bd9275c378
provide init command for database
All checks were successful
InnoHub Processor/tatort/pipeline/pr-main This commit was not built
Details
InnoHub Processor/tatort/pipeline/head This commit was not built
Details
809c355849
trachi93 reviewed 2025-07-22 11:30:32 +02:00
trachi93 reviewed 2025-07-22 11:31:10 +02:00
package.json Outdated
@@ -45,2 +46,4 @@
"@tailwindcss/forms": "^0.5.10",
"autoprefixer": "^10.4.21",
"better-sqlite3": "^12.2.0",
"crypto": "^1.0.1",
trachi93 commented 2025-07-22 11:31:10 +02:00
Author
Owner
Copy Link

[JB] Das crypto package ist deprecated. Hier müsste eine alternastive her vielleicht: https://www.npmjs.com/package/crypto-js

[JB] Das crypto package ist deprecated. Hier müsste eine alternastive her vielleicht: https://www.npmjs.com/package/crypto-js
trachi93 commented 2025-07-23 12:58:29 +02:00
Author
Owner
Copy Link

wurde entfernt

wurde entfernt
trachi93 marked this conversation as resolved
trachi93 reviewed 2025-07-22 11:31:33 +02:00
src/init/init_db.js Outdated
@@ -0,0 +1,45 @@
import Database from 'better-sqlite3';
trachi93 commented 2025-07-22 11:31:33 +02:00
Author
Owner
Copy Link

[JB] Bitte als typescript datei: init-db.ts

[JB] Bitte als typescript datei: init-db.ts
trachi93 marked this conversation as resolved
trachi93 reviewed 2025-07-22 11:32:15 +02:00
src/init/init_db.js Outdated
@@ -0,0 +20,4 @@
let usersSQLStmt = `SELECT * FROM USERS`;
let SQLStatement = db.prepare(usersSQLStmt);
console.log(`\n`, `*** Users table`);
trachi93 commented 2025-07-22 11:32:15 +02:00
Author
Owner
Copy Link

[JB] console.log entfernen

[JB] console.log entfernen
trachi93 marked this conversation as resolved
trachi93 reviewed 2025-07-22 11:33:11 +02:00
src/routes/(angemeldet)/upload/+page.server.ts
@@ -47,3 +66,3 @@
const vorgang = data.vorgang;
const name = data.name;
const zugangscode = data.zugangscode;
const password = data.password;
trachi93 commented 2025-07-22 11:33:11 +02:00
Author
Owner
Copy Link

[JB] Was meint hier password? Ist es nicht der vorgangstoken?

[JB] Was meint hier password? Ist es nicht der vorgangstoken?
trachi93 commented 2025-07-23 12:59:31 +02:00
Author
Owner
Copy Link

Projektweite Umbenennung erfolgt im separaten branch.

Projektweite Umbenennung erfolgt im separaten branch.
jared marked this conversation as resolved
trachi93 reviewed 2025-07-22 11:33:35 +02:00
src/routes/(angemeldet)/upload/+page.svelte
@@ -18,3 +18,3 @@
const code_len = 8;
function generate_token() {
function generatePassword() {
trachi93 commented 2025-07-22 11:33:35 +02:00
Author
Owner
Copy Link

[JB] Ich würde es nicht Password nennen, entweder vorgangsPassword oder vorgangsToken oder so und das stringent durch, an allen Codestellen.

[JB] Ich würde es nicht Password nennen, entweder vorgangsPassword oder vorgangsToken oder so und das stringent durch, an allen Codestellen.
jared marked this conversation as resolved
trachi93 reviewed 2025-07-22 11:34:33 +02:00
src/routes/api/list/[vorgang]/code/+server.ts Outdated
@@ -1,24 +1,15 @@
import { client } from '$lib/minio';
import { db } from '$lib/server/dbService';
trachi93 commented 2025-07-22 11:34:33 +02:00
Author
Owner
Copy Link

[JB] Der Pfad [vorgang]/code/.. sollte geändert werden in die entsprechende Vokabel also zugangstoken o. ä. s.o.

[JB] Der Pfad [vorgang]/code/.. sollte geändert werden in die entsprechende Vokabel also zugangstoken o. ä. s.o.
trachi93 marked this conversation as resolved
trachi93 added 3 commits 2025-07-23 12:54:58 +02:00
remove unused and deprecated crypto package 26c05b4999
rename .js to .ts and remove console.logs statements e8170de947
move ´code´ api endpoint to ´casepw´
Some checks failed
InnoHub Processor/tatort/pipeline/head There was a failure building this commit
Details
db1cc78f2c
trachi93 added 1 commit 2025-07-23 12:55:23 +02:00
Merge branch 'development' into f034_sqlite_database
Some checks failed
InnoHub Processor/tatort/pipeline/head There was a failure building this commit
Details
addcc26a07
trachi93 commented 2025-07-23 13:00:45 +02:00
Author
Owner
Copy Link

@jared
Feedback wurde umgesetzt, außer die beiden Renaming-Kommentare. Diese wollten wir ja global separat betrachten.

@jared Feedback wurde umgesetzt, außer die beiden Renaming-Kommentare. Diese wollten wir ja global separat betrachten.
jared added 1 commit 2025-07-24 14:30:29 +02:00
fix package-lock.json
All checks were successful
InnoHub Processor/tatort/pipeline/head This commit looks good
Details
ee9d9fa8fc
jared merged commit 542c12cc5f into development 2025-07-24 14:34:39 +02:00
jared deleted branch f034_sqlite_database 2025-07-24 14:34:39 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
trachi93
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
christoph Daniel git jared mina titus trachi93
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: innohub/tatort#19
Delete Branch "f034_sqlite_database"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?