innohub/tatort
7
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

f086_Zusatz-Edit-der-Namen #34

Merged
mina merged 13 commits from f086_Zusatz-Edit-der-Namen into development 2025-09-24 12:40:12 +02:00
Conversation 2 Commits 13 Files Changed 9 +449 -216
mina commented 2025-09-12 10:26:20 +02:00
Owner
Copy Link

implement Änderungen von Karte 86, inklusive diverser Funktionalitätstests

implement Änderungen von Karte 86, inklusive diverser Funktionalitätstests
mina added 12 commits 2025-09-12 10:26:20 +02:00
implement test View Leere Liste in TatortListe edb37d8117
implement test VorgangList view fedc781d74
Merge branch 'development' into f102_test_KeineListeVorhanden eaf74c9a5a
add tetId now tests client-view all passed 7c20aa08b4
change VorgangsListPage in VorgangListPage 18a37a0e6b
kleine Änderungen, copied baseData, change names of tests 14509fdffe
implement test verschiedene Buttons beim click von editButton 38cdaa538a
implement tests, Tatort List , ComponentEmptyList refactoring 650cfd0061
implement tests TatortList.view, check delete/edit Item 8803187ce1
save changes, bin aber noch nicht fertig 47ca05f2d4
fixed tests and Code edit and delete Name in TatortList bcf24122bc
implement testsNameItemEditor funktionalität 012f7ee3e8
mina changed title from f086_Zusatz-Edit-der-Namen to WIP: f086_Zusatz-Edit-der-Namen 2025-09-12 10:26:43 +02:00
mina changed title from WIP: f086_Zusatz-Edit-der-Namen to f086_Zusatz-Edit-der-Namen 2025-09-12 10:26:57 +02:00
mina added 1 commit 2025-09-22 11:15:10 +02:00
fixed crimesList aktualisiert sich nach dem Editing 03835fe624
trachi93 commented 2025-09-23 11:54:13 +02:00
Owner
Copy Link

Wenn ich im Editier-Modus bin, und außerhalb klicke, wird es nicht abgebrochen.

Wenn ich im Editier-Modus bin, und außerhalb klicke, wird es nicht abgebrochen.
trachi93 added 1 commit 2025-09-23 13:23:19 +02:00
comment usage of props with old syntax 5d2cfa6dfd
trachi93 added 1 commit 2025-09-24 09:48:43 +02:00
formatting: fixtures.ts file b4591d044b
trachi93 added 1 commit 2025-09-24 09:56:14 +02:00
formatting: VorgangList.view.test.ts 406e7f8e4d
trachi93 added 1 commit 2025-09-24 11:01:41 +02:00
formatting 011c07b753
trachi93 requested changes 2025-09-24 11:44:52 +02:00
src/lib/components/NameItemEditor.svelte Outdated
@@ -22,3 +18,1 @@
let error: string = $derived(validateName(localName));
let isEditing = $state(false);
let inputRef: HTMLInputElement;
let localName = currentName;
trachi93 commented 2025-09-23 11:59:32 +02:00
Owner
Copy Link

unnoetig? currentName ist auch nicht initiiert.

unnoetig? currentName ist auch nicht initiiert.
trachi93 marked this conversation as resolved
src/routes/(token-based)/list/[vorgang]/+page.svelte Outdated
@@ -27,2 +27,4 @@
}
let crimesList = $state<ListItem[]>(data.crimesList);
$inspect('debug Edit', crimesList);
trachi93 commented 2025-09-23 11:47:33 +02:00
Owner
Copy Link

debug raus

debug raus
mina marked this conversation as resolved
src/routes/(token-based)/list/[vorgang]/+page.svelte Outdated
@@ -39,3 +40,2 @@
//Variable um nur admin UI anzuzeigen
let admin = data?.user?.admin;
let admin = $state(data?.user?.admin);
trachi93 commented 2025-09-23 11:48:46 +02:00
Owner
Copy Link

ist dies notwendig?
admin wird noch nicht dynamisch verwendet o. ä.

ist dies notwendig? `admin` wird noch nicht dynamisch verwendet o. ä.
mina marked this conversation as resolved
src/routes/(token-based)/list/[vorgang]/+page.svelte Outdated
@@ -44,2 +44,4 @@
open = true;
inProgress = true;
isError = false;
console.log('debug handleSave', newName, oldName);
trachi93 commented 2025-09-24 08:21:44 +02:00
Owner
Copy Link

debug raus

debug raus
mina marked this conversation as resolved
mina closed this pull request 2025-09-24 12:02:17 +02:00
mina reopened this pull request 2025-09-24 12:02:35 +02:00
mina added 2 commits 2025-09-24 12:37:16 +02:00
Merge branch 'development' into f086_Zusatz-Edit-der-Namen 0c05cf6661
deleted debug comments 3a6b10e860
mina merged commit dc44a2f4ce into development 2025-09-24 12:40:12 +02:00
mina deleted branch f086_Zusatz-Edit-der-Namen 2025-09-24 12:40:13 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
trachi93
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
christoph Daniel git jared mina titus trachi93
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: innohub/tatort#34
Delete Branch "f086_Zusatz-Edit-der-Namen"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?